Fix character list generator #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
char_list_fix
branch
from
5834183 to
793b9e3
Compare
zherczeg
force-pushed
the
char_list_fix
branch
from
793b9e3 to
aae7778
Compare
Member
|
Great, thank you so much Zoltan for looking into this! The fix is in the sort of area where I expected it to be. But I'd need to spend some time to review exactly how the structures work before I can double-check the fix. It looks good though. |
Collaborator
Author
|
I would like to land this fix before I completely forget about it. |
Member
|
!! I did forget about it, my apologies. Please, do merge it. |
Member
|
This commit is a definite candidate for a backport to older versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.